The lyricist met Elton John in 1967 when they each responded to an ad for songwriters. Their collaboration has spanned more than five decades